On-ramp: Refactor Payment Methods view to componentization #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
force-pushed
the
refactor/onramp-payment-methods-view
branch
from
4457d23
to
9cc98c4
Compare
wachunei
added
needs-dev-review
wachunei
commented
Feb 21, 2023
app/components/UI/FiatOnRampAggregator/Views/PaymentMethods/PaymentMethods.tsx
Outdated
Show resolved
Hide resolved
wachunei
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR changes the folder structure for the Payment Methods View in the on-ramp flow, adding tests with 100% coverage.
Screenshots/Recordings
Skeleton for Payment Method was updated
Before - After
Issue
Progresses #???
Checklist