Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Screenshot deterrent analytics #5468

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
The trackEvent method from AnalyticsV2 wouldn't work if the params passed were empty.

2. What is the improvement/solution?
Add a new condition to solve this issue.

Object.keys(params).length === 0

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.14.0 labels Jan 10, 2023
@gantunesr gantunesr marked this pull request as ready for review January 10, 2023 11:43
@gantunesr gantunesr requested a review from a team as a code owner January 10, 2023 11:43
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 10, 2023
@gantunesr gantunesr merged commit 473623b into main Jan 10, 2023
@gantunesr gantunesr deleted the fix/screenshot-analytics branch January 10, 2023 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants