Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-ramp: upgrade on-ramp-sdk to v1.6.1 #5473

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This small bumps restores the behavior of some methods to how they were in versions <1.6.0.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 labels Jan 11, 2023
@wachunei wachunei requested a review from a team as a code owner January 11, 2023 11:13
Copy link

@deeeed deeeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wachunei wachunei merged commit 2706808 into main Jan 11, 2023
@wachunei wachunei deleted the chore/onramp-upgrade-sdk-1.6.1 branch January 11, 2023 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2023
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants