Fix import of isEIP1559Transaction
#5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of `isEIP1559Transaction` was not working; that function was accidentally removed from the package exports in a recent update. It has been updated to import directly from the util files in the package instead. This is a temporary solution. We will also update the `@metamask/transaction-controller` package to export this method, so we don't need to reference a file internal to the package. This is being fixed like this for now so that we don't have to wait for the package update, because the next package update will be a lot of work.
|
This function is exported in this PR: MetaMask/core#1058 |
Gudahtt
added
the
needs-dev-review
wachunei
added
No QA Needed/E2E Only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The import of
isEIP1559Transactionwas not working; that function was accidentally removed from the package exports in a recent update. It has been updated to import directly from the util files in the package instead.This is a temporary solution. We will also update the
@metamask/transaction-controllerpackage to export this method, so we don't need to reference a file internal to the package. This is being fixed like this for now so that we don't have to wait for the package update, because the next package update will be a lot of work.Checklist