Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: update "Install the Android NDK" #5476

Merged
merged 4 commits into from
Jan 11, 2023
Merged

README.md: update "Install the Android NDK" #5476

merged 4 commits into from
Jan 11, 2023

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jan 11, 2023 •
edited

Description

Update Android instructions in README.md:

  • adds "Install Java" instructions
  • updates "Install the Android NDK"
  • updates Android emulator instructions

@digiwand digiwand added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr
Copy link
Member

@digiwand you need to sign the SLA by commenting,

I have read the CLA Document and I hereby sign the CLA

@digiwand
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@digiwand digiwand marked this pull request as ready for review January 11, 2023 19:40
@digiwand digiwand requested a review from a team as a code owner January 11, 2023 19:40
@digiwand digiwand merged commit 370226c into main Jan 11, 2023
@digiwand digiwand deleted the readme-update-install-android-ndk branch January 11, 2023 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2023
@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.14.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@digiwand @gantunesr