Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy update for metamask fee on swaps #5495

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

nikoferro
Copy link
Member

@nikoferro nikoferro commented Jan 13, 2023

Description

Minor copy update to match fee description on other platforms

Issue

See MMS-402

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Before
before
After
after

@nikoferro nikoferro requested a review from a team as a code owner January 13, 2023 13:09
@nikoferro nikoferro added swaps MetaSwaps issues Code Impact - Low Minor code change that can safely applied to the codebase release-5.14.0 labels Jan 13, 2023
@cortisiko
Copy link
Member

hey @nikoferro I don't have access to the ticket in the PR description. Do you mind posting the screenshots in the description? Before and After screenshots. And since this is merely a copy change, I am happy with labeling this "Spot Check on the Release Branch".

@nikoferro
Copy link
Member Author

hey @cortisiko , just added the before/after pics, let me know when u have a sec if its ready to squash and merge. thanks!

@cortisiko cortisiko added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Jan 17, 2023
@cortisiko
Copy link
Member

@nikoferro thanks for updating. I will add the spot check on release build label and merge.

@cortisiko cortisiko merged commit 8d4ef16 into MetaMask:main Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase release-5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking swaps MetaSwaps issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants