Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: Add NavBar tests to GetStarted and Regions Views #5506

Merged
merged 3 commits into from
Jan 18, 2023
Merged

On-ramp: Add NavBar tests to GetStarted and Regions Views #5506

merged 3 commits into from
Jan 18, 2023
+1,427 −224

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This PR adds to GetStarted and Regions Views:

  • Missing rendering of the Navigation Bar
  • Tests of the navigation and analytics events

Bringing coverage to 100%:

_getstartedcoverage
_regionscoverage

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added tests Test related issues No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Jan 13, 2023
@wachunei wachunei requested a review from a team as a code owner January 13, 2023 19:43
sethkfman
sethkfman approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit 49c8f5e into main Jan 18, 2023
@wachunei wachunei deleted the chore/onramp-get-started-regions-test branch January 18, 2023 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.14.0 team-ramp issues related to Ramp features tests Test related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @sethkfman