Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-ramp: Fix order link in details screen #5550

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes a conditional rendering bug that was rendering the empty string outside of a Text component.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 labels Jan 19, 2023
@wachunei wachunei requested a review from a team as a code owner January 19, 2023 13:01
@wachunei wachunei force-pushed the fix/onramp-order-details-link branch from 305139e to fc12b25 Compare January 19, 2023 13:02
@wachunei wachunei changed the base branch from main to release/5.14.0 January 19, 2023 13:05
@wachunei wachunei merged commit 4ce8476 into release/5.14.0 Jan 19, 2023
@wachunei wachunei deleted the fix/onramp-order-details-link branch January 19, 2023 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants