Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANALYTICS] Add analytics metrics for SRP reveal #5559

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

Add the analytics events for the feature "Add friction to SRP reveal"

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/592

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 20, 2023
@gantunesr gantunesr marked this pull request as ready for review January 20, 2023 21:36
@gantunesr gantunesr requested a review from a team as a code owner January 20, 2023 21:36
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 20, 2023
@gantunesr gantunesr merged commit 7f54f36 into main Jan 20, 2023
@gantunesr gantunesr deleted the feat/srp-reveal/metrics branch January 20, 2023 22:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants