Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Refactor ProtectYourWallet section in the security section #5600

Merged
merged 17 commits into from
Jan 25, 2023

Conversation

gantunesr
Copy link
Member

Description

Refactor ProtectYourWallet section in the security section to TS, functional component, and move the code to their on file.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Part of https://github.com/MetaMask/mobile-planning/issues/591

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jan 25, 2023
@gantunesr gantunesr marked this pull request as ready for review January 25, 2023 05:06
@gantunesr gantunesr requested a review from a team as a code owner January 25, 2023 05:06
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🙌🏿

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 25, 2023
@gantunesr gantunesr merged commit 764a008 into main Jan 25, 2023
@gantunesr gantunesr deleted the refactor/reveal-priv-credential branch January 25, 2023 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants