Handle ENS Address Error

[blackdevelopa]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add needs-qa label when dev review is completed
5. Add QA Passed label when QA has signed off

Description
When an ENS name does not have an address registered, we expect to return an error to users. However, on mobile evan.eth currently resolves to 0x0000.....0000. See reported issue.

On mobile, ethjs-ens is used for resolving ens addresses. There's a known issue on said package. From the code, this PR returns when the resolvedAddress is 0x0000000000000000000000000000000000000000

Test Case
tested on mainnet

• Tap to send eth
• Enter evan.eth on the receiver (to) input

Screenshots/Recordings
http://recordit.co/4c3dFLDytL

Issue

Progresses #5396

Scenario: Send to unregistered ENS address
Given I am attempting a send transaction
When I enter an ENS name not pointed to an eth address in the TO field
Then I am NOT able to complete a send transaction destined to 0x000...0000

Scenario: Send to 0's manually
Given I am attempting a send transaction
When I manually type/paste '0x0000000000000000000000000000000000000000' in the TO field
Then I am able to complete a send transaction destined to 0x000...0000

Scenario: Send to 0's saved as a contact
Given I have previously saved a contact with destination address '0x0000000000000000000000000000000000000000'
When I attempt a send transaction
And I select this previously saved contact as a destination in the TO field
Then I am able to complete a send transaction destined to 0x000...0000

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[plasmacorral]

This breaks deeplink payment requests to ENS addresses. This functions in production v5.13 build 1042 on my device (Samsung a515f w/Android11).

This can be tested by either tapping on a deeplink or scanning it as a QR code from wallet view.

Video: https://recordit.co/ftn5q2HgMU

Expectation: Should be presented confirmation and have the chance to submit the transaction

Current State: Just returned to wallet view after engaging a payment deeplink to ENS address

Some example deeplinks:

https://metamask.app.link/send/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48@1/transfer?address=evan.ethereum.eth&uint256=1e4

https://metamask.app.link/send/pay-metarnask.eth@1?value=1e13

[plasmacorral]

EDIT: Looks like this may be an issue on main

Ok...we made a production build to rule out any deeplinking issues in the debug build. While payment deeplinks now work in build 1053 when a user clicks on them, they are still not functioning when scanned from the Qr scanner at wallet view.

Please test with these sample QR codes:

[plasmacorral]

Tested:

• Valid ENS deeplink Eth payment
• Valid ENS deeplink ERC20 payment
• Invalid ENS deeplink
• Intentionally sending to 0x000...000 to burn an asset
• Payment deeplink on testnet without ENS
• Deeplink to DAPP

Note that scanning a QR to deeplink is broken on main currently, so this was not successfully tested.

Turns out this is an issue on main, not from this branch.