Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry/5.14.0 fix analytics #5615

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Cherry/5.14.0 fix analytics #5615

merged 1 commit into from
Jan 26, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jan 26, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Cherry pick @gantunesr fix for analytics. The issue was that the events in MP were showing as mp_event rather than the actual event name itself. Equivalent PR that merges into main - #5613

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner January 26, 2023 17:43
@Cal-L Cal-L changed the base branch from main to release/5.14.0 January 26, 2023 17:43
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client labels Jan 26, 2023
cortisiko
cortisiko approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@sethkfman sethkfman merged commit aeae97b into release/5.14.0 Jan 26, 2023
@sethkfman sethkfman deleted the cherry/5.14.0-fix-analytics branch January 26, 2023 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Cal-L @cortisiko @gauthierpetetin @sethkfman @gantunesr