Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SRP Quiz content and translations #5626

Merged
merged 1 commit into from
Jan 27, 2023
Merged

[FIX] SRP Quiz content and translations #5626

merged 1 commit into from
Jan 27, 2023
+43 −43

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jan 27, 2023 •
edited

Description

Fix some small details in the content and translations for the SRP Quiz feature.

  • Trailing space
  • Uppercase in french content
  • Misplaced period

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/591

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts labels Jan 27, 2023
@gantunesr gantunesr marked this pull request as ready for review January 27, 2023 13:22
@gantunesr gantunesr requested a review from a team as a code owner January 27, 2023 13:22
NicolasMassart
NicolasMassart reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the FR part.

tommasini
tommasini approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 27, 2023
@gantunesr gantunesr merged commit bf81d9b into main Jan 27, 2023
@gantunesr gantunesr deleted the feat/srp-quiz/content-fix branch January 27, 2023 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
@gantunesr gantunesr added release-6.0.0 PRs for v6.0.0 release and removed release-6.1.0 labels Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@jpcloureiro jpcloureiro jpcloureiro approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.0.0 PRs for v6.0.0 release team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gantunesr @jpcloureiro @NicolasMassart @tommasini