[IMPROVEMENT] Use Set when filtering blocklist

[Cal-L]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add needs-qa label when dev review is completed
5. Add QA Passed label when QA has signed off

Description

This PR patches the PhishingController to use Set when filtering on the blocklist. The improvement here (at least testing locally on iOS) is that look up in Set vs using includes while filtering reduces same business logic processing time by 4x. This translates to a user experiencing 4x faster cold start times than before.

Issue

Progresses #5382

Test

We should expect cold start times on iOS to be ~4seconds, while Android (depending on device) shouldn't take more than 10 seconds. (Both times reported by Curtis). Relative to the previous app version, the cold start up times should be noticeably lower.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[chrisleewilcox]

Test Scenarios:

• Multiple (numerous) browser tabs opened and connected to websites and dapps (opensea, uni, 1inch, reddit, etc...)
• Navigate through opensea
• Navigate throughout app while numerous browser tabs connected (Settings, Activity, Wallet view, Import and Request tokens, etc...)
• Execute transactions while numerous browser tabs connected (Send, Swap, QR scan, HW transactions, etc...)

Expected: mobile app usage is not negatively impacted

[chrisleewilcox]

Issue #1: Browser: opensea.io: tapping MetaMask icon on connect wallet takes you download MetaMask page.
Expected: Wallet connects to opensea
https://recordit.co/cVKsYZSFgx

[chrisleewilcox]

Please review issues.

[chrisleewilcox]

Issue 2: Uniswap: Swaps: UI components for token rate on swap screen are not loading
https://recordit.co/a5Gi54FKyu
https://recordit.co/oRTeCz3M7C

NOTE: This currently exist in prod but sites/dapps that are not loading UI fully may be contributing to slowness. This is not a Uniswap specific issue but this issue is using Uniswap as a specific example.

[cortisiko]

Regarding Issue 1 I cannot reproduce it on a physical device: http://recordit.co/qzgkprczPr
And sim: http://recordit.co/kKp5jKeIo7

Maybe opensea was having a connectivity issue earlier in the day.

Regarding issue 2, This seems dapp specific. Uniswap has Skelton loaders that appear for swap prices.

[cortisiko]

Looks good to me!