Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add introductory image to SRP Quiz #5647

Merged
merged 5 commits into from
Jan 31, 2023
Merged

[IMPROVEMENT] Add introductory image to SRP Quiz #5647

merged 5 commits into from
Jan 31, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jan 31, 2023 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

Add introductory image to SRP Quiz.

Screenshots/Recordings

  1. Android - Dark Mode

  1. iOS - Light Mode

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/591

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.0.0 PRs for v6.0.0 release labels Jan 31, 2023
@gantunesr gantunesr marked this pull request as ready for review January 31, 2023 13:56
@gantunesr gantunesr requested a review from a team as a code owner January 31, 2023 13:56
@gantunesr gantunesr added the design-review Any feature that needs feedback from the design team label Jan 31, 2023
blackdevelopa
blackdevelopa approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 31, 2023
@holantonela
Copy link

Looks awesome, thanks @gantunesr

@gantunesr gantunesr merged commit 8117d99 into main Jan 31, 2023
@gantunesr gantunesr deleted the improvement/srp-friction/intro-image branch January 31, 2023 17:25
@gantunesr gantunesr removed the design-review Any feature that needs feedback from the design team label Jan 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-6.0.0 PRs for v6.0.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @holantonela @blackdevelopa