Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design-tokens version and remove screen size from TextVariants #5679

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Update design-tokens version and remove screen size from TextVariants #5679

merged 6 commits into from
Feb 7, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Updated design-tokens version and remove screen size from TextVariants
  • Updated usage of TextVariants to equivalent token sans screen size

Screenshots/Recordings

Screenshot 2023-02-03 at 11 16 27 AM

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 3, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 3, 2023 19:18
@brianacnguyen brianacnguyen self-assigned this Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen merged commit a7989ac into main Feb 7, 2023
@brianacnguyen brianacnguyen deleted the morph/update-ds-tokens-5617 branch February 7, 2023 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @jpcloureiro