Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentize TextInput #5682

Merged
merged 3 commits into from
Feb 4, 2023
Merged

Conversation

brianacnguyen
Copy link
Contributor

Description

Added TextInput to Morph

Screenshots/Recordings

Simulator Screen Shot - iPhone 11 Pro - 2023-02-03 at 13 53 38
Simulator Screen Shot - iPhone 11 Pro - 2023-02-03 at 13 53 43

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 3, 2023
@brianacnguyen brianacnguyen self-assigned this Feb 3, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 3, 2023 21:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment

@brianacnguyen brianacnguyen merged commit 0f506e7 into main Feb 4, 2023
@brianacnguyen brianacnguyen deleted the morph/componentize-text-input-5680 branch February 4, 2023 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants