Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Updated ButtonBase to use flex-start instead of baseline #5713

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

Updated ButtonBase to not use 'baseline' due to ReactNative's yoga's 'baseline' function still being unstable. Updated to use 'flex-start' instead.

@brianacnguyen brianacnguyen requested a review from a team as a code owner February 6, 2023 16:40
@brianacnguyen brianacnguyen self-assigned this Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title Updated ButtonBase to use flex-start instead of baseline [FIX] Updated ButtonBase to use flex-start instead of baseline Feb 6, 2023
@brianacnguyen brianacnguyen merged commit c830fc7 into main Feb 6, 2023
@brianacnguyen brianacnguyen deleted the fix/baseline-issue-5712 branch February 6, 2023 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants