Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated button usage to use full width #5717

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Updated button usage to use full width #5717

merged 2 commits into from
Feb 7, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Feb 7, 2023 •
edited

Description

Updated button usage to use full width

Screenshots/Recordings

![Simulator Screen Shot - iPhone 11 Pro - 2023-02-06 at 17 29 33](https://user-image
Simulator Screen Shot - iPhone 11 Pro - 2023-02-07 at 11 41 05
s.githubusercontent.com/14355083/217125121-f01ee47c-a8a1-4626-bbc2-c0b9de3f5414.png)
Simulator Screen Shot - iPhone 11 Pro - 2023-02-07 at 11 55 59
![Simulator Screen Shot - iPhone 11 Pro - 2023-02-07 at 11 56 05](https://user-images.gith
Simulator Screen Shot - iPhone 11 Pro - 2023-02-07 at 12 06 15
ubusercontent.com/14355083/217354043-336e7357-2be6-43fc-87d3-b6ae27143ec8.png)
Simulator Screen Shot - iPhone 11 Pro - 2023-02-07 at 12 07 04

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 7, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 7, 2023 01:31
@brianacnguyen brianacnguyen self-assigned this Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston
Copy link
Contributor

what is your opinion on making this prop mandatory?

@owencraston
Copy link
Contributor

Looks like its working on the buttons I mentioned had issues...
Screenshot_1675792948
Screenshot_1675792961

Have you tested these other instances of the button?
Screenshot 2023-02-07 at 10 09 47 AM

@brianacnguyen
Copy link
Contributor Author

Looks like its working on the buttons I mentioned had issues... Screenshot_1675792948 Screenshot_1675792961

Have you tested these other instances of the button? Screenshot 2023-02-07 at 10 09 47 AM

Updated screenshots with cases listed

@brianacnguyen
Copy link
Contributor Author

what is your opinion on making this prop mandatory?

Since the default behavior is auto and is commonly auto, making it required means that every time a dev needs to use a button, they have to pass in the width object. This can be tiring for auto cases. Having it optional will make it easier for auto cases and will make sure when the button is full width it is intentionally done so

owencraston
owencraston approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@brianacnguyen brianacnguyen merged commit bc85edd into main Feb 7, 2023
@brianacnguyen brianacnguyen deleted the fix/button-width-5716 branch February 7, 2023 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @owencraston