Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Minor UI bugs in credential views #5726

Merged
merged 3 commits into from
Feb 8, 2023
Merged

[FIX] Minor UI bugs in credential views #5726

merged 3 commits into from
Feb 8, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Feb 8, 2023 •
edited

Description

The credential views (SRP & Private key) have several UI bugs. This PR solves three of them,

  • Button "Reveal Secret Recovery Phrase" wrong width

  • SRP Quiz wrong button variant

  • Views title

Screenshots/Recordings

Images above

Issue

Progresses #X

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr marked this pull request as ready for review February 8, 2023 11:50
@gantunesr gantunesr requested a review from a team as a code owner February 8, 2023 11:50
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.1.0 labels Feb 8, 2023
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 8, 2023
@gantunesr gantunesr merged commit be7b736 into main Feb 8, 2023
@gantunesr gantunesr deleted the fix/minor-ui-bugs branch February 8, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees
No one assigned
Labels
release-6.1.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @jpcloureiro