Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sideway/formula audit #5744

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix sideway/formula audit #5744

merged 1 commit into from
Feb 9, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 9, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Updating yarn.lock sideway/formula version to fix build issue related to audit

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses Audit report

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner February 9, 2023 20:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.0.0 PRs for v6.0.0 release labels Feb 9, 2023
@Cal-L Cal-L merged commit 4ae721a into main Feb 9, 2023
@Cal-L Cal-L deleted the audit/patch-audit-sideway/formula branch February 9, 2023 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.0.0 PRs for v6.0.0 release team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants