Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e appium/add splash animation step #5748

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Feb 10, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
In a previous pr, the waitForSplashAnimation() method was moved to a separated steps to prevent having duplicated code. So in this ticket i added the new step to the scenarios affected by this change.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas
Copy link
Member Author

Browserstack test runs:

./wdio/features/Accounts/CreatingWalletAccount.feature
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/a61ceff40f9b6838856edb2c0359609bced2c840?auth_token=1a1470525eac3442727ac5a19aa1d599a7c6bf23a98781e999b4df7780d017f4

ImportingAccount.feature
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/5b9f26e6f0696fd86e592e6c1effa56617d38221?auth_token=a45b675356bf26f5c3d0d1d5cc1e04abb5093a78dea2dfe93bc6a52a60608f19

/wdio/features/LockResetWallet.feature
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/25a5dff85f3775b35b5c68cf885f56067d520617?auth_token=3a1adda6cebab73215d596e08bc39a9a31df94d42c5a0b408a8d82372575eb29

/wdio/features/ImportCustomToken.feature
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/5f0b85e04ae17f6df648806b9997d91b29f7596e?auth_token=2eed21728f7d92924a61da24c1cf9dd390b27ef9cd9ecc69952de8d01826c503

/wdio/features/AddressFlow.feature
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/bd7e3457330cccb02f6f966c0022249248c94e57?auth_token=5f694849a67fb533169a97287f13722f126e049fdf5088c5fa98a282a54e2039

/wdio/features/NetworkFlow.feature - failed
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/7347b7dab29a2155a3b43521bf1abeb22d3b2d0c?auth_token=3ae9946cff1f3278d38adb7cdb9dd66947eecb5f787b202a90b6cee3d1f4ed4f

/wdio/features/ExploringWizard.feature - failed
https://app-automate.browserstack.com/builds/af352c3cb4fc61986127b52d3b21c37a2213b608/sessions/fc31ed0b36d61e106564fa527f3d53d068437d05?auth_token=b8091dfd5f1498fd653f23f0ea49bed47b2cc76dca46cffd0bf67f734bd819a7

@SamuelSalas SamuelSalas merged commit 264a509 into main Feb 10, 2023
@SamuelSalas SamuelSalas deleted the e2e-appium/add-splash-animation-step branch February 10, 2023 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "When the app displayed the splash animation" step to other feature files.
3 participants