Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Enable clipboard for private credentials #5750

Merged
merged 2 commits into from
Feb 25, 2023
Merged

[FIX] Enable clipboard for private credentials #5750

merged 2 commits into from
Feb 25, 2023

Conversation

gantunesr
Copy link
Member

Description

Fix missing clipboard CTA for iOS and Android (> 10).

Screenshots/Recordings

Issue

Progresses #5593

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts labels Feb 10, 2023
@gantunesr gantunesr marked this pull request as ready for review February 10, 2023 04:16
@gantunesr gantunesr requested a review from a team as a code owner February 10, 2023 04:16
NicolasMassart
NicolasMassart reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gantunesr just 2 noob questions because review helps me to understand code.
Thanks!

blackdevelopa
blackdevelopa approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left this #5750 (comment)

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 14, 2023
@olenapankina olenapankina added QA in Progress QA has started on the feature. needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Feb 15, 2023
@plasmacorral plasmacorral added release-6.2.0 QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 24, 2023
@plasmacorral
Copy link
Contributor

LGTM!

e2e tests passed

Device OS existance Private key SRP Password change Error on PK reveal with Keystone selected
Pixel 5a Android 13 Physical Copy-PASS Copy-PASS PASS  
Samsung a515f Android 11 Physical Copy-PASS Copy-PASS PASS PASS
iPhone Xs iOS 16 Physical Copy with 1 min timer-PASS Copy with 1 min timer-PASS PASS PASS
iPhone 13 mini iOS 15 Physical Copy with 1 min timer-PASS Copy with 1 min timer-PASS PASS PASS
Galaxy A8 Android 7.1 Browserstack No copy-PASS No copy-PASS PASS  
Google Pixel 2 Android 8 Browserstack No copy-PASS No copy-PASS PASS  
Galaxy S10 Android 9 Browserstack No copy-PASS No copy-PASS PASS  
Xiaomi redmi note 9 Android 10 Browserstack Copy-PASS Copy-PASS PASS  
Galaxy tab S8 Android 12 Browserstack Copy-PASS Copy-PASS PASS  

@plasmacorral plasmacorral added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Feb 25, 2023
@plasmacorral plasmacorral merged commit 36f56e7 into main Feb 25, 2023
@plasmacorral plasmacorral deleted the fix/credential-clipboard branch February 25, 2023 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.2.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gantunesr @plasmacorral @NicolasMassart @blackdevelopa @olenapankina