Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPGRADE] Segment Analytics 2.13.0 #5768

Merged
merged 3 commits into from
Feb 15, 2023
Merged

[UPGRADE] Segment Analytics 2.13.0 #5768

merged 3 commits into from
Feb 15, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Feb 14, 2023 •
edited
Loading

Description

Upgrade @segment/analytics-react-native from 2.9.0 to 2.13.0 and update patch.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/372

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 14, 2023
@gantunesr gantunesr marked this pull request as ready for review February 14, 2023 22:53
@gantunesr gantunesr requested a review from a team as a code owner February 14, 2023 22:53
Cal-L
Cal-L reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

patches/@segment+analytics-react-native+2.13.0.patch Outdated Show resolved Hide resolved
patches/@segment+analytics-react-native+2.13.0.patch Outdated Show resolved Hide resolved
patches/@segment+analytics-react-native+2.13.0.patch Outdated Show resolved Hide resolved
@gantunesr gantunesr requested a review from Cal-L February 15, 2023 12:16
Cal-L
Cal-L approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.1.0 Issue or pull request that will be included in release 6.1.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 15, 2023
@gantunesr gantunesr merged commit 06f9e49 into main Feb 15, 2023
@gantunesr gantunesr deleted the upgrade/segment-analytics-react-native-2.13.0 branch February 15, 2023 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-6.1.0 Issue or pull request that will be included in release 6.1.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @Cal-L