-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add portfolio button to asset action buttons #5785
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Co-authored-by: Cal Leung <cleun007@gmail.com>
…k-mobile into me/entry-point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meppsilon questions for you:
1.
Should a new browser tab always open when I tap on the portfolio button? Right now if I were to connect to the pdapp via the portfolio button > return to the wallet > tap on the portfolio button again, a new browser tab opens up. If I repeat this n
times then I will have n
browser tabs opened for the portfolio dapp.
See recording
2
Maybe this is something the design team can answer:
With languages such as Russian or Filipino, there are ellipsis that prevents the users from seeing the full text on the buttons
Hey @cortisiko,
|
hey @meppsilon following up on our conversation in the release planning this week, did we come to a conclusion on issue 1? |
Alrighty @meppsilon I tested this PR again. The good news is, the browser tab does not open multiple tabs when I tap the pdapp button. The bad news: I also observed that if the pdapp is open in a separate browser tab while another dapp or website is currently active, and I close and relaunch the pdapp, upon tapping on the browser button, the pdapp automatically opens up: http://recordit.co/0olVVc2d4f In prod this is not the case. With your PR, this changes the way the browser works. See behavior in prod: http://recordit.co/cizlY3qsJI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR looks good @meppsilon 🌮 🌮 🌮
…to me/entry-point
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR adds a button to the wallet view that, when clicked, opens the browser to the portfolio dapp. We hope that this feature improves mobile users experience by providing them with quick access to additional portfolio-specific views.
Screenshots/Recordings
Issue
Progresses #???
Checklist