Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds 'ios' and 'android' to MM SDK sources #5791

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

andreahaku
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku requested a review from a team as a code owner February 20, 2023 15:37
@andreahaku andreahaku self-assigned this Feb 20, 2023
@andreahaku andreahaku added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 20, 2023
@andreahaku andreahaku added the Code Impact - Low Minor code change that can safely applied to the codebase label Feb 20, 2023
@gantunesr gantunesr added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Feb 20, 2023
@andreahaku andreahaku merged commit d87bae8 into main Feb 20, 2023
@andreahaku andreahaku deleted the feature/sdk-adds-ios-source-events branch February 20, 2023 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants