[IMPROVEMENT] Delete update PhishingController on app start #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
tommasini
added
needs-dev-review
jpcloureiro
approved these changes
Feb 20, 2023
tommasini
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve the app start time this PR it was deleted the update of phishingListController from the Engine because it was already being done on the BrowserTab component
The difference between 6.0.0 and this one it's small under good network conditions, but definitely will improve with worst network conditions since it's less one endpoint that we call during our app start that loads a good amount of data.
Screenshots/Recordings
Phishing controller reproduction:
https://recordit.co/DGSeZnZe0T
App start time with qa build without importing account:
https://recordit.co/81dk9Nvwjf
App start time with qa build with 5 accounts imported:
https://recordit.co/LU8aMJmmeg
Test cases:
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #https://github.com/MetaMask/mobile-planning/issues/627
Checklist