-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX] Browser: handle unsupported URLs #5799
[HOTFIX] Browser: handle unsupported URLs #5799
Conversation
this will prevent app crashes when url is malformed & let the error be handled
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
We are already using this polyfill: https://github.com/charpeni/react-native-url-polyfill which apparently follows the whatwg standard for |
Invalid URL error handling needs to be implemented before replacing In this case
This hotfix will prevent users from being stuck on the error boundary screen. A proper way to handle URLs should be implemented next |
Ahhh I see. I thought you meant that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jpcloureiro what is expected if user has coingecko app installed on device? Will coingecko app open? Can you confirm this? Will need this confirmed in development before handing this over to QA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my comments about behavior for coingecko app on device.
@chrisleewilcox I would say this is the expected behaviour for this PR as well. |
Description
In-App browser do not handle special URLs (deeplinks like market://details?...)
Change from native URL API to
url-parse
package.This allows the app to handle unsupported URLs instead of throwing an error.
Screenshots/Recordings
Screen that will appear when the user tries to use a special URL / deeplink inside In-App browser
Issue
Progresses #5794