Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry: remove DSN value from codebase #5803

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Sentry: remove DSN value from codebase #5803

merged 2 commits into from
Feb 23, 2023

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Feb 21, 2023 •
edited

Description

Remove Sentry DSN from the codebase & load it from environment variables.

Sentry SDK won't send any events when DSN is not defined

For non Metamask developers there's a reference in the README markdown on what to do if they want to log app events on their own Sentry project.

Issue

Progresses https://github.com/metamask/mobile-planning/issues/580

@jpcloureiro jpcloureiro requested a review from a team as a code owner February 21, 2023 16:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro self-assigned this Feb 21, 2023
@jpcloureiro jpcloureiro added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. and removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Feb 21, 2023
sethkfman
sethkfman reviewed Feb 23, 2023
View reviewed changes
README.md Show resolved Hide resolved
sethkfman
sethkfman approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 23, 2023
@jpcloureiro jpcloureiro merged commit 7af6067 into main Feb 23, 2023
@jpcloureiro jpcloureiro deleted the feat/sentry-dsn-key branch February 23, 2023 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@jpcloureiro jpcloureiro

Labels
release-6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpcloureiro @sethkfman @gauthierpetetin @Cal-L