Add "preview build" support to Bitrise #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
consolidate-bitrise-setup
branch
from
de37271
to
7d47353
Compare
Gudahtt
force-pushed
the
consolidate-bitrise-setup
branch
5 times, most recently
from
b7c2d96
to
cc2e59f
Compare
Gudahtt
force-pushed
the
bitrise-preview-builds
branch
2 times, most recently
from
5bcf466
to
7d54bca
Compare
The Bitrise workflows for QA builds and e2e tests now support using "preview builds" from the core monorepo [1]. The release builds still won't work with preview builds, which should ensure we don't accidentally include a preview build in a release. [1]: https://github.com/MetaMask/core/blob/main/docs/contributing.md#using-packages-in-other-projects-during-developmenttesting
Gudahtt
force-pushed
the
bitrise-preview-builds
branch
from
7d54bca
to
bdbc6c9
Compare
|
This is now ready for review. Test builds on Bitrise are still running, but they've gotten past the install step at least. Here's a run on this branch: https://app.bitrise.io/build/61f64eaf-9bf1-40bc-bf69-a281d7933eb3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The Bitrise workflows for QA builds and e2e tests now support using "preview builds" from the core monorepo. The release builds still won't work with preview builds, which should ensure we don't accidentally include a preview build in a release.
Issue
I don't think there is an issue for this yet, and I'm not sure which work it most directly relates to.
Checklist