[CONTENT] Ledger Integration english content #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
needs-dev-review
blackdevelopa
approved these changes
Feb 22, 2023
gantunesr
added
release-6.1.0
and removed
needs-dev-review
| "how_to_install_eth_app": "How to install the Ethereum app on a Ledger device", | ||
| "ledger_account_count": "You are using 1 account from your Ledger with MetaMask Mobile.", | ||
| "open_eth_app": "Please open the Ethereum app", | ||
| "open_eth_app_message_one": "We’ve detected you have the Ethereum app installed but it’s not open, please ", |
There was a problem hiding this comment.
Remove please. This action is required to continue and not only if it pleases the user.
Suggested change
| "open_eth_app_message_one": "We’ve detected you have the Ethereum app installed but it’s not open, please ", | |
| "open_eth_app_message_one": "Ethereum app is installed but not open, please ", |
| "unknown_error_message": "An unexpected error occured. Please try again.", | ||
| "error_occured": "An error occured", | ||
| "how_to_install_eth_app": "How to install the Ethereum app on a Ledger device", | ||
| "ledger_account_count": "You are using 1 account from your Ledger with MetaMask Mobile.", |
There was a problem hiding this comment.
Is the number hardcoded or maybe it requires some placeholder? Also if placeholder, handle plurals.
| "ethereum_app_not_installed_error": "Please install the Ethereum app on your Ledger device.", | ||
| "ledger_is_locked": "Ledger is locked", | ||
| "unlock_ledger_message": "Please unlock your Ledger device", | ||
| "cannot_get_account": "Cannot get account", |
There was a problem hiding this comment.
language style matching
Suggested change
| "cannot_get_account": "Cannot get account", | |
| "cannot_get_account": "Can't get account", |
| "ledger_account_count": "You are using 1 account from your Ledger with MetaMask Mobile.", | ||
| "open_eth_app": "Please open the Ethereum app", | ||
| "open_eth_app_message_one": "We’ve detected you have the Ethereum app installed but it’s not open, please ", | ||
| "open_eth_app_message_two": "press the two buttons on the device to accept the prompt to open the Ethereum app to continue.", |
There was a problem hiding this comment.
Capitalise first word.
Sentence is too complicated. Can we simplify with like:
Suggested change
| "open_eth_app_message_two": "press the two buttons on the device to accept the prompt to open the Ethereum app to continue.", | |
| "open_eth_app_message_two": "Press both buttons on the Ledger device to open Ethereum app.", |
| "open_eth_app": "Please open the Ethereum app", | ||
| "open_eth_app_message_one": "We’ve detected you have the Ethereum app installed but it’s not open, please ", | ||
| "open_eth_app_message_two": "press the two buttons on the device to accept the prompt to open the Ethereum app to continue.", | ||
| "toast_bluetooth_connection_error_title": "Oops, something went wrong :/", |
There was a problem hiding this comment.
I noticed that we already replaced the "oops" by something better in other prompts to make them more actionable.
| "cannot_get_account": "Cannot get account", | ||
| "connect_ledger": "Connect Ledger", | ||
| "looking_for_device": "Looking for device", | ||
| "ledger_reminder_message": "Please make sure your Ledger Nano X is:", |
There was a problem hiding this comment.
We say Ledger all along, and here it's Ledger Nano X... what if we support other models later?
| "available_devices": "Available devices", | ||
| "retry": "Retry", | ||
| "continue": "Continue", | ||
| "confirm_transaction_on_ledger": "Confirm transaction by pressing two buttons on your Ledger", |
There was a problem hiding this comment.
Suggested change
| "confirm_transaction_on_ledger": "Confirm transaction by pressing two buttons on your Ledger", | |
| "confirm_transaction_on_ledger": "Confirm transaction by pressing both buttons on your Ledger", |
| "bluetooth_enabled_message": "Make sure Bluetooth is enabled", | ||
| "device_unlocked_message": "Device is unlocked", | ||
| "blind_signing_message": "Blind signing is enabled", | ||
| "ledger_disconnected": "Your device got disconnected", |
There was a problem hiding this comment.
Suggested change
| "ledger_disconnected": "Your device got disconnected", | |
| "ledger_disconnected": "Your device is disconnected", |
| "ledger_disconnected": "Your device got disconnected", | ||
| "ledger_disconnected_error": "The connection to your device has been lost. Please try again.", | ||
| "unknown_error": "Unexpected error occurred.", | ||
| "unknown_error_message": "An unexpected error occured. Please try again.", |
There was a problem hiding this comment.
Error are most of the time unexpected...
Suggested change
| "unknown_error_message": "An unexpected error occured. Please try again.", | |
| "unknown_error_message": "An unknown error occured. Please try again.", |
But I would even fusion this with the error_occured one... knowing it's unexpected or unknown doesn't add anything ot the user understanding. It just makes them more anxious...
| "forget_device": "Forget Ledger", | ||
| "sign_with_ledger": "Sign with Ledger", | ||
| "ledger_pending_confirmation": "Ledger is busy", | ||
| "ledger_pending_confirmation_error": "There is a pending action on your Ledger. Please clear the action first then retry.", |
There was a problem hiding this comment.
Suggested change
| "ledger_pending_confirmation_error": "There is a pending action on your Ledger. Please clear the action first then retry.", | |
| "ledger_pending_confirmation_error": "An action is in progress on your Ledger. Please finish or cancel the action, then retry.", |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Add english content for the Ledger integration.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses https://github.com/MetaMask/mobile-planning/issues/637
Checklist