Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Send Token E2E test #5825

Merged
merged 15 commits into from
Mar 1, 2023
Merged

[Improvement] Send Token E2E test #5825

merged 15 commits into from
Mar 1, 2023

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Feb 23, 2023 •
edited

Description

  • SendToken Flow originating from this ticket
  • Increased Appium test coverage
  • Minor implementations to improve test runs
  • PR based on deprecated PR 5793 with resolved comments
    ScreenShots
    Local test run:

image

Browserstack test successful runs X3:
1 - https://app-automate.browserstack.com/dashboard/v2/builds/be5310c82607f6abeeb859c3db73cfc6112c2f55/sessions/5c13b2805691db2580f319962941791e4ad89fde
2 - https://app-automate.browserstack.com/dashboard/v2/builds/be5310c82607f6abeeb859c3db73cfc6112c2f55/sessions/e2dae7067d83f8031c2ddad4ac7479105997448a
3- https://app-automate.browserstack.com/dashboard/v2/builds/be5310c82607f6abeeb859c3db73cfc6112c2f55/sessions/a94b38101f748c07620e7777e4ecc2f21ea3a007

Failing tests

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Andepande Andepande requested a review from a team as a code owner February 23, 2023 13:12
NicolasMassart
NicolasMassart reviewed Feb 23, 2023
View reviewed changes
wdio.conf.js Show resolved Hide resolved
wdio/features/SendToken.feature Show resolved Hide resolved
wdio/features/SendToken.feature Show resolved Hide resolved
wdio/features/SendToken.feature Outdated Show resolved Hide resolved
wdio/features/SendToken.feature Show resolved Hide resolved
wdio/features/SendToken.feature Show resolved Hide resolved
wdio/screen-objects/AmountScreen.js Outdated Show resolved Hide resolved
wdio/step-definitions/import-tokens.steps.js Show resolved Hide resolved
cortisiko
cortisiko requested changes Feb 26, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments. We will need to put our wallet keys behind an env variable to prevent loss of funds. We can discuss it tomorrow.

wdio/helpers/Gestures.js Outdated Show resolved Hide resolved
wdio/screen-objects/AmountScreen.js Outdated Show resolved Hide resolved
wdio/screen-objects/AmountScreen.js Outdated Show resolved Hide resolved
wdio/screen-objects/TokenOverviewScreen.js Outdated Show resolved Hide resolved
wdio/step-definitions/common-steps.js Show resolved Hide resolved
@cortisiko
Copy link
Member

A couple more things:

  • Rename this PR. [Improvement] Send Token E2E test
  • Fix the listing issues.

@MetaMask MetaMask deleted a comment Feb 27, 2023
@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2023
@Andepande Andepande changed the title Working Send token test [Improvement] Send Token E2E test Feb 27, 2023
cortisiko
cortisiko approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@Andepande Andepande merged commit 137171f into main Mar 1, 2023
@Andepande Andepande deleted the e2e/appium-546-send-erc-token branch March 1, 2023 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@cortisiko cortisiko cortisiko approved these changes

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

Assignees
No one assigned
Labels
Appium needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andepande @cortisiko @NicolasMassart @SamuelSalas @sethkfman