Update order of browser page load events #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
NicholasEllul
force-pushed
the
ellul/browser-loading-update
branch
from
b6b8d9f
to
99c6d7c
Compare
NicholasEllul
force-pushed
the
ellul/browser-loading-update
branch
from
99c6d7c
to
940914f
Compare
NicholasEllul
added
the
needs-dev-review
leotm
previously approved these changes
May 18, 2023
sethkfman
approved these changes
May 25, 2023
sethkfman
added
No QA Needed/E2E Only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Addresses https://github.com/MetaMask/mobile-planning/issues/976 by improving the way we load events on the pages. This should allow for us to reduce redundant loads of phishing page unless the user explicitly decides they would like to proceed to that page.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
https://github.com/MetaMask/mobile-planning/issues/976
Checklist