Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/674 network search crash #5851

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Bug/674 network search crash #5851

merged 2 commits into from
Feb 28, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 28, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes 2 bugs in 6.1.0 regression

  1. Fix network search crasher - #674
network_search.mov
  1. Fix button width not stretching on custom url screen
custom_rpc_cta.mov

Issue reported by @cortisiko
https://www.screencast.com/t/ijuHhv2C

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner February 28, 2023 01:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the base branch from main to release/6.1.0 February 28, 2023 01:57
@Cal-L Cal-L added release-6.1.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working Mobile QA board labels Feb 28, 2023
chrisleewilcox
chrisleewilcox approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit dc31bf7 into release/6.1.0 Feb 28, 2023
@chrisleewilcox chrisleewilcox deleted the bug/674-network-search-crash branch February 28, 2023 02:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
@chrisleewilcox chrisleewilcox added the QA Passed A successful QA run through has been done label Feb 28, 2023
@chrisleewilcox chrisleewilcox removed the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.1.0 type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cal-L @chrisleewilcox