Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC 0.5][Feature] Scan QR icon on wallet view #5859

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 1, 2023

Description
Change scan qr code icon on wallet view.
Added some testing on the wallet component as well.

Screenshots/Recordings

Working on android physical device:
https://recordit.co/CKK00dChQi

Issue

Progresses #

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner March 1, 2023 02:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2023
@tommasini tommasini added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Mar 1, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job adding test cases!

@tommasini tommasini removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2023
@tommasini tommasini merged commit ac01749 into main Mar 1, 2023
@tommasini tommasini deleted the implement/653-mc-wallet-scan-icon branch March 1, 2023 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
@gauthierpetetin gauthierpetetin changed the title [Feature] Scan QR icon on wallet view [MC 0.5][Feature] Scan QR icon on wallet view Apr 10, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants