Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-ramp: Add buy crypto home button #5870

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Mar 1, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds a Buy <Token> button on the wallet home when the user has 0 balance and the network is supported buy the buy feature.

Strategic rationale
We're using the empty space to get users off a zero balance—it's low-hanging fruit. New users need ETH/gas to submit transactions, and from user research, we know there needs to be more awareness of our On-ramp feature (and even Swaps).

Furthermore, we have data indicating the popularity of a previous iteration of this button. For example, in Sep 2021, this button received [n]M clicks, more than the smaller button. This simple button can significantly increase On-ramp engagement from new users/empty accounts.

Screenshots/Recordings

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.2.0 labels Mar 1, 2023
@wachunei wachunei force-pushed the feature/onramp-empty-wallet-home branch from 25f3679 to 58dc7ce Compare March 1, 2023 19:20
@wachunei wachunei marked this pull request as ready for review March 1, 2023 19:22
@wachunei wachunei requested a review from a team as a code owner March 1, 2023 19:22
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, build on iPhone and tested. Nice work!

app/components/UI/Tokens/index.js Show resolved Hide resolved
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 6, 2023
@wachunei wachunei merged commit b5c31ad into main Mar 7, 2023
@wachunei wachunei deleted the feature/onramp-empty-wallet-home branch March 7, 2023 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants