Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display internet protocol on the new origin pill (Update) #5880

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

blackdevelopa
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This PR updates other parts of connect account origin pill. It's a follow up to #5842

Screenshots/Recordings
Before
http://recordit.co/2pDs12ZKVp

After
http://recordit.co/A7k9I5e4fl

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 2, 2023 12:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Mar 2, 2023
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 2, 2023
app/images/static-logos.js Outdated Show resolved Hide resolved
@blackdevelopa blackdevelopa added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-confirmations-secure-ux-PR PR from the confirmations team and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 2, 2023
@blackdevelopa blackdevelopa merged commit 1bdb6bf into main Mar 2, 2023
@blackdevelopa blackdevelopa deleted the fix/show_protocol_origin_pill_update branch March 2, 2023 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants