Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip type checking library declaration files #5882

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Skip type checking library declaration files #5882

merged 1 commit into from
Mar 22, 2023

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Mar 2, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Fix: #5881

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

cc @Cal-L @gantunesr

@leotm leotm requested a review from a team as a code owner March 2, 2023 12:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

leotm added a commit that referenced this pull request Mar 16, 2023
@leotm
Fix 18 JS type errors exposing 683 TS/TSX errors
dae1e1d 
Minimum required to tackle remaining errors in 120 files

Follow-up to: #5879

Fix: #5878

Next: #5882
@leotm leotm mentioned this pull request Mar 16, 2023
Merged
3 tasks
@leotm leotm added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 17, 2023
Cal-L
Cal-L approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leotm added a commit that referenced this pull request Mar 22, 2023
@leotm
Fix 18 JS type errors for TSC to output 683 TS/TSX errors (#5975)
d3f01d4 
* Fix 18 JS type errors exposing 683 TS/TSX errors

Minimum required to tackle remaining errors in 120 files

Follow-up to: #5879

Fix: #5878

Next: #5882

* Fix app/core/Engine.ts lint errors

* Revert "Fix app/core/Engine.ts lint errors"

This reverts commit 7ac7011.

* Fix app/core/Engine.ts lint errors
@leotm leotm merged commit 39654d8 into MetaMask:main Mar 22, 2023
@leotm leotm deleted the fix/skip-type-check-lib-declaration-files branch March 22, 2023 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type checking library declaration files
3 participants
@leotm @Cal-L @gantunesr