Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap with wallet connect is broken #5890

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Swap with wallet connect is broken #5890

merged 7 commits into from
Mar 10, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Mar 3, 2023 •
edited

Description
Thanks to Tomas and Joao, we have a fix for https://github.com/MetaMask/mobile-planning/issues/684

Test Cases

  • Test swap with wallet connect

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Test Case

  1. In-app browser: http://recordit.co/mEiHOhDSSc
  2. WC: http://recordit.co/MOhMJLIH7P
  3. Deeplink via QR code: https://recordit.co/Zr6eYUKPQg
  4. Deeplink: http://recordit.co/lY7oJVnSG4 (Unable to deeplink on dev env)

Not tested:

  1. MM SDK from iOS app
  2. unity

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/684

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 3, 2023 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Show resolved Hide resolved
app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
@blackdevelopa blackdevelopa self-assigned this Mar 9, 2023
Cal-L
Cal-L reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Do you mind also providing videos to show the different scenarios

app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionHeader/ApproveTransactionHeader.tsx Outdated Show resolved Hide resolved
app/components/UI/TransactionReview/index.js Outdated Show resolved Hide resolved
@Cal-L Cal-L added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.2.0 labels Mar 9, 2023
@blackdevelopa blackdevelopa added team-confirmations-secure-ux-PR PR from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Mar 9, 2023
Cal-L
Cal-L approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 9, 2023
cortisiko
cortisiko approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed.

I tested:

  • swaps
  • contract deploy, approvals
  • sending funds (ERC20, NFTs, native)
  • keystone transactions (sign, swap, send, deploy contracts)

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 10, 2023
@cortisiko cortisiko merged commit ad4f6e8 into main Mar 10, 2023
@cortisiko cortisiko deleted the fix-transaction-review branch March 10, 2023 00:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini left review comments

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-6.2.0 team-confirmations-secure-ux-PR PR from the confirmations team unit test coverage confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blackdevelopa @Cal-L @cortisiko @tommasini @hilvmason