Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] E2E Permission system tests #5910

Merged
merged 28 commits into from
Mar 22, 2023
Merged

[ENHANCEMENT] E2E Permission system tests #5910

merged 28 commits into from
Mar 22, 2023

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Mar 7, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds e2e test coverage for the permission system.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko changed the title E2E Permission system tests [ENHANCEMENT] E2E Permission system tests Mar 8, 2023
@cortisiko cortisiko marked this pull request as ready for review March 8, 2023 02:20
@cortisiko cortisiko requested a review from a team as a code owner March 8, 2023 02:20
@cortisiko
Copy link
Member Author

Browserstack runs for the tests: https://app-automate.browserstack.com/dashboard/v2/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/2bdb86881041963750f251b97e450e384c6a00cd

and this: https://app-automate.browserstack.com/dashboard/v2/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/4425a4290f1ec7c39490765de1f7af18fed0a898

@cortisiko
Copy link
Member Author

Detox is pending. Will leave a message with the build run later.

Andepande
Andepande approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to provide screenshots of the test run and links to Browserstack runs?

@cortisiko
Copy link
Member Author

Are you able to provide screenshots of the test run and links to Browserstack runs?

For sure I got you:
#5910 (comment)

@cortisiko cortisiko merged commit a803bec into main Mar 22, 2023
@cortisiko cortisiko deleted the e2e/enhace-browser-coverage branch March 22, 2023 03:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@Andepande Andepande Andepande approved these changes

Assignees
No one assigned
Labels
team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortisiko @SamuelSalas @Andepande @gauthierpetetin