Componentize Banner Component #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to morph/componentize-banners
brianacnguyen
added
the
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
team-design-system
No QA Needed/E2E Only
|
I noticed in the screenshots that the padding between the icon and the left border looks a bit off.
|
|
good catch. the border just needs to be inside. will update |
Cal-L
reviewed
Mar 9, 2023
app/component-library/components/Banners/Banner/variants/BannerTip/index.ts
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerTip/README.md
Outdated
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerTip/README.md
Outdated
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerTip/README.md
Outdated
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerTip/README.md
Outdated
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/foundation/BannerBase/BannerBase.styles.ts
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerAlert/index.ts
Show resolved
Hide resolved
app/component-library/components/Banners/Banner/variants/BannerTip/BannerTip.styles.ts
Outdated
Show resolved
Hide resolved
…to morph/componentize-banners
Cal-L
added
release-6.4.0
…to morph/componentize-banners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings
BannerAlert
BannerTip
Issue
Progresses #???
Checklist