Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove select address as a prop on App index.js #5962

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 14, 2023

Description

This PR fixes the bug where the account sheet re-renders after the mutation of an account. This includes creating, importing, or removing. The solution was to remove selectedAddress from the props to prevent re-render triggers.

Screenshots/Recordings

Reach out to @Cal-L on slack for video

Issue
#5911

Testing

  • Scenario: Account sheet should be on multi-select after the creation of an account

    • Given I am on the Browser view
    • When I tap on the right button on the Nav bar
    • And I tap on Connect more accounts
    • And I tap on Create a new account
    • Then a new account should be created
    • And we should still be on the account multi-select screen
  • Scenario: Repeat the above scenario but import an account or remove instead

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner March 14, 2023 01:34
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added release-6.3.0 PR for release 6.3.0 type-bug Something isn't working Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 14, 2023
@Cal-L Cal-L changed the title Remove select address as a prop on App index.js [FIX] Remove select address as a prop on App index.js Mar 14, 2023
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. I did not verify the fix but the code looks good.

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this PR fixes #5911

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Mar 14, 2023
@Cal-L Cal-L added release-6.2.0 and removed release-6.3.0 PR for release 6.3.0 labels Mar 14, 2023
@Cal-L Cal-L merged commit 0c4f95a into main Mar 14, 2023
@Cal-L Cal-L deleted the bug/5911-account-sheet-reset branch March 14, 2023 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
@Cal-L Cal-L restored the bug/5911-account-sheet-reset branch March 14, 2023 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-6.2.0 team-mobile-platform type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants