Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC 0.5][FEATURE] Account selector on swaps screen #5997

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 20, 2023

Description
This PR aims to add account selector to the swaps screen, the reason for this it's when the user uses the new wallet action button (button on the center of the bottom tab menu), they can be on a dapp with a different selected address, that way if they try to swap, they will understand which account are they using

Test Steps

  • Go to swaps
  • Change the account on account selector
  • Notice every time you change the account, the swap state reset to the initial state

Screenshots/Recordings
Ability to switch accounts on Swaps screen: https://recordit.co/SnpmupJKI3
Account shown on Swaps screen is not synced with the active Dapp accounts: https://recordit.co/BzWPZtujiA
Account change on Swaps screen reset the swap screen: https://recordit.co/RrwuwcJUcT

Removing imported account via the swaps screen: https://recordit.co/Va4ZTyDTmQ
creating an account with a long name then going to the swaps view: https://recordit.co/z0WBeOZTmg
Import account via the account selector from dapp connect modal via the browser then remove the imported account via the swaps account selector: https://recordit.co/OK7YaukMnU

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner March 20, 2023 14:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 20, 2023
app/components/UI/Swaps/index.js Outdated Show resolved Hide resolved
app/components/UI/Swaps/index.js Show resolved Hide resolved
app/components/UI/Swaps/index.js Show resolved Hide resolved
@Cal-L Cal-L added release-6.3.0 PR for release 6.3.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-client labels Mar 21, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L changed the title [FEARTURE][MC] Account selector on swaps screen [FEARTURE] Account selector on swaps screen Mar 21, 2023
@Cal-L Cal-L changed the title [FEARTURE] Account selector on swaps screen [FEATURE] Account selector on swaps screen Mar 21, 2023
@tommasini tommasini removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 21, 2023
@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 23, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 23, 2023
@chrisleewilcox chrisleewilcox merged commit c581774 into main Mar 23, 2023
@chrisleewilcox chrisleewilcox deleted the feature/718-account-selector-swaps branch March 23, 2023 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Mar 23, 2023
@gauthierpetetin gauthierpetetin changed the title [FEATURE] Account selector on swaps screen [MC 0.5][FEATURE] Account selector on swaps screen Apr 10, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-6.3.0 PR for release 6.3.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants