Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding document to refactor send flow #6003

Merged
merged 20 commits into from
Mar 29, 2023
Merged

Adding document to refactor send flow #6003

merged 20 commits into from
Mar 29, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 21, 2023

Ref: #5946

Architectural document for send page. It also include code cleanup we should do in these components.

The document can be read here: https://github.com/MetaMask/metamask-mobile/tree/send_architectural_doc/docs/confirmation-refactoring/send#readme

@jpuri jpuri requested a review from a team as a code owner March 21, 2023 10:28
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri and others added 7 commits March 21, 2023 21:32
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
…sk/metamask-mobile into signature_request_refactoring_doc
jpuri and others added 3 commits March 22, 2023 11:42
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Base automatically changed from signature_request_refactoring_doc to main March 24, 2023 11:52
Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I added some NIT to fix typos.

Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
@jpuri jpuri merged commit efc25d3 into main Mar 29, 2023
@jpuri jpuri deleted the send_architectural_doc branch March 29, 2023 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants