-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sentry version and enable performance metrics #6015
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Pull request alert summary
📊 Modified Dependency Overview:
|
@SocketSecurity @sentry/cli@1.75.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just please look at what is failing on the pipeline
This needs further change in sample rate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C: prevent including unrelated formatting changes in the PR.
The wdio folder is excluded from linter so this will not make your PR fail if you don't apply prettier to it.
@SocketSecurity ignore @sentry/cli@1.75.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fix the yarn.lock conflicts and it can be merged
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR aims to add support for new Sentry Performance monitoring metrics.
Gotchas:
Screenshots/Recordings
![Screen Shot 2023-03-22 at 09 22 28](https://user-images.githubusercontent.com/575479/226857657-fa1da8ea-ffce-405c-8101-b8bb015a64e1.png)
Issue
Progresses #???
Checklist