Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: Add accessibility label to custom action images #6016

Merged
merged 2 commits into from
Mar 22, 2023
Merged

On-ramp: Add accessibility label to custom action images #6016

merged 2 commits into from
Mar 22, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Mar 22, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PRs add an accessibility label to the images used in buttons for some providers. The issue we were facing was screen readers were reading "Buy With" instead of "Buy With < image label >".

An SDK patch version bump is needed which includes the label type update.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Mar 22, 2023
@wachunei wachunei requested a review from a team as a code owner March 22, 2023 12:24
@wachunei wachunei changed the title Add accessibility label to custom action images On-ramp: Add accessibility label to custom action images Mar 22, 2023
@wachunei wachunei added release-6.3.0 PR for release 6.3.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 22, 2023
@wachunei wachunei merged commit 32e03b3 into main Mar 22, 2023
@wachunei wachunei deleted the feature/onramp-a11y-custom-action-label branch March 22, 2023 21:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
release-6.3.0 PR for release 6.3.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Fatxx