Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add url-parse lib to our MainNavigator #6025

Merged
merged 2 commits into from
Mar 24, 2023
Merged

[FIX] Add url-parse lib to our MainNavigator #6025

merged 2 commits into from
Mar 24, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 23, 2023 •
edited by Cal-L

Description
The glob class URL of react native it's not handling correctly some urls
We should use the url-parse

cc: @witmicko

Issue

Having issues with connecting the ticket, but listed here.
Progresses https://github.com/MetaMask/mobile-planning/issues/741

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner March 23, 2023 12:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 23, 2023
andreahaku
andreahaku approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 23, 2023
@tommasini tommasini added the release-6.3.0 PR for release 6.3.0 label Mar 24, 2023
Cal-L
Cal-L approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Mar 24, 2023
@Cal-L Cal-L merged commit 4c127c0 into main Mar 24, 2023
@Cal-L Cal-L deleted the fix/url-parsing-wrongly branch March 24, 2023 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
@Cal-L Cal-L restored the fix/url-parsing-wrongly branch March 24, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-6.3.0 PR for release 6.3.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tommasini @andreahaku @Cal-L @gauthierpetetin