-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle to enable/disable multi account balances fetching #6026
Add toggle to enable/disable multi account balances fetching #6026
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Find my changes in a branch you can merge in this PR if it looks fine for you: fix/add-opt-out-toggle-for-batching-balances...nico/5321_add-opt-out-toggle-for-batching-balances |
…o fix/add-opt-out-toggle-for-batching-balances # Conflicts: # app/components/Views/Settings/SecuritySettings/index.js
…//github.com/MetaMask/metamask-mobile into fix/add-opt-out-toggle-for-batching-balances
…ing-balances' into fix/add-opt-out-toggle-for-batching-balances
...omponents/Views/AccountConnect/AccountConnectSingleSelector/AccountConnectSingleSelector.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/AccountConnect/AccountConnectMultiSelector/AccountConnectMultiSelector.tsx
Outdated
Show resolved
Hide resolved
…//github.com/MetaMask/metamask-mobile into fix/add-opt-out-toggle-for-batching-balances
# Conflicts: # wdio/screen-objects/testIDs/Screens/SecurityPrivacy.testIds.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fatxx sending this back your way:
-
Translations are missing.
-
I cannot see analytic events:
- Locally when I enable and disable “batch account balance requests”
- In a preproduction version of the app: I had an iOS version of the QA app > I went ahead and toggled “batch account balance requests” to off, but when I searched mix panel the analytics did not appear.
What wasn't tested:
upgrading the app from a previous version to a version containing this PR. Can we kick off a release build for this branch?
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request Pull request alert summary
|
# Conflicts: # app/components/UI/AccountInfoCard/__snapshots__/index.test.tsx.snap # app/components/UI/AccountInfoCard/index.test.tsx # app/components/UI/AnimatedTransactionModal/index.test.tsx # locales/languages/en.json # wdio/screen-objects/testIDs/Components/AccountListComponent.testIds.js # wdio/step-definitions/import-wallet-via-private-key.steps.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment
wdio/screen-objects/testIDs/Components/AccountListComponent.testIds.js
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
We decided not to handle the requested change in this PR
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
1. What is the reason for the change?
As explained in #5321, users have to be able to choose if they want to query for their accounts balance in batch or one account at a time.
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Wallet Screen Selector: https://recordit.co/1jIXqGlCAg
Dapp Account Selector: https://recordit.co/OxepxVgHa0
Issue
Progresses #5321
Testing
See QA builds in Bitrise build #6686
Checklist