Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Android setup instructions #6039

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 24, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The step of installing CMake has been added to the Android setup instructions. This tool is required by react-native-reanimated.

The name of the "Preferences" menu has also been updated to "Settings", which is what it's called in later versions of Android Studio.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

The step of installing `CMake` has been added to the Android setup
instructions. This tool is required by `react-native-reanimated`.

The name of the "Preferences" menu has also been updated to "Settings",
which is what it's called in later versions of Android Studio.
@Gudahtt Gudahtt marked this pull request as ready for review March 24, 2023 13:13
@Gudahtt Gudahtt requested a review from a team as a code owner March 24, 2023 13:13
@Gudahtt Gudahtt added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Mar 24, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Gudahtt Gudahtt merged commit 50747a1 into main Mar 24, 2023
@Gudahtt Gudahtt deleted the improve-android-setup-instructions branch March 24, 2023 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants