Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TagURL #6054

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Improve TagURL #6054

merged 3 commits into from
Jun 16, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Mar 28, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This PR updates tag url to origin instead of active tab url.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #681

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 28, 2023 09:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Mar 28, 2023
@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Mar 28, 2023
jpuri
jpuri previously approved these changes Apr 7, 2023
View reviewed changes
NiranjanaBinoy
NiranjanaBinoy previously approved these changes Apr 12, 2023
View reviewed changes
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 13, 2023
@seaona seaona added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 14, 2023
@seaona
Copy link
Contributor

seaona commented Apr 18, 2023 •
edited

I've found an issue in this PR and I reported it here @blackdevelopa

@seaona seaona added QA'd but questions A QA run through has been done but you need clarification on minor issues you found and removed QA in Progress QA has started on the feature. labels Apr 18, 2023
@seaona seaona removed the QA'd but questions A QA run through has been done but you need clarification on minor issues you found label Apr 25, 2023
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2023
jpuri
jpuri previously approved these changes May 16, 2023
View reviewed changes
segun
segun previously approved these changes May 17, 2023
View reviewed changes
@blackdevelopa blackdevelopa removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 18, 2023
@blackdevelopa blackdevelopa dismissed stale reviews from segun and jpuri via 38f1488 June 15, 2023 09:31
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

62.1% 62.1% Coverage
65.4% 65.4% Duplication

@seaona seaona added the QA Passed A successful QA run through has been done label Jun 15, 2023
@seaona
Copy link
Contributor

seaona commented Jun 15, 2023

@blackdevelopa I could repro the issue on prod and I cannot repro the issue in the PR. Meaning the issue seems to be fixed 💯 Adding QA Pass and can be merged whenever we get the 2 approvals (seems they were reset)

@seaona seaona merged commit 3ebbbb0 into main Jun 16, 2023
13 checks passed
@seaona seaona deleted the bg_163/improv_tagurl branch June 16, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segun segun segun approved these changes

@jpuri jpuri jpuri approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-7.2.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blackdevelopa @seaona @segun @jpuri @NiranjanaBinoy